koordlet: add metrics about be used cpu and node used memory #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
==========================================
- Coverage 66.04% 66.04% -0.01%
==========================================
Files 454 457 +3
Lines 53438 53751 +313
==========================================
+ Hits 35295 35501 +206
- Misses 15601 15699 +98
- Partials 2542 2551 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leason00
changed the title
|
/assign @zwzhang0107 |
saintube
changed the title
saintube
reviewed
Dec 4, 2024
pkg/koordlet/metricsadvisor/collectors/beresource/be_resource_collector.go
Outdated
Show resolved
Hide resolved
leason00
force-pushed
the
be_used_cpu_cores
branch
from
254e04b to
913a2e4
Compare
|
@saintube Please review again |
saintube
reviewed
Dec 5, 2024
pkg/koordlet/metricsadvisor/collectors/beresource/be_resource_collector.go
Outdated
Show resolved
Hide resolved
Signed-off-by: lisen <[email protected]>
leason00
force-pushed
the
be_used_cpu_cores
branch
from
913a2e4 to
192fd68
Compare
lijunxin559
pushed a commit
to lijunxin559/koordinator
that referenced
this pull request
Dec 10, 2024
…ator-sh#2283) Signed-off-by: lisen <[email protected]> Co-authored-by: lisen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
metric of newly added BE resource usage.
It has the following functions：
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test