Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ginkgo to v2.11.0 #2284

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

nce3xin
Copy link
Contributor

@nce3xin nce3xin commented Nov 29, 2024

Ⅰ. Describe what this PR does

Fix #1964
Upgrade the ginkgo version to v2.11.0 to facilitate E2E reporting.

Ⅱ. Does this pull request fix one issue?

Yes, #1964

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.04%. Comparing base (13a7107) to head (a8005d8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
- Coverage   66.04%   66.04%   -0.01%     
==========================================
  Files         454      454              
  Lines       53438    53438              
==========================================
- Hits        35295    35292       -3     
- Misses      15601    15605       +4     
+ Partials     2542     2541       -1     
Flag Coverage Δ
unittests 66.04% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nce3xin nce3xin force-pushed the main-upgrade-ginkgo branch 6 times, most recently from 1bd2b3f to f84b4e1 Compare November 29, 2024 14:32
@nce3xin nce3xin force-pushed the main-upgrade-ginkgo branch from f84b4e1 to a8005d8 Compare November 29, 2024 15:34
@nce3xin
Copy link
Contributor Author

nce3xin commented Nov 29, 2024

PTAL @saintube

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube added the lgtm label Dec 2, 2024
@saintube
Copy link
Member

saintube commented Dec 3, 2024

PTAL /cc @jasonliu747

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot merged commit 46c7604 into koordinator-sh:main Dec 3, 2024
22 checks passed
j4ckstraw pushed a commit to j4ckstraw/koordinator that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Upgrade ginkgo to 2.x
3 participants