Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: add log for cpu/mem numaaware allocate #2293

Merged

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.04%. Comparing base (053d636) to head (565e78d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...duler/plugins/nodenumaresource/resource_manager.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2293   +/-   ##
=======================================
  Coverage   66.03%   66.04%           
=======================================
  Files         457      457           
  Lines       53751    53755    +4     
=======================================
+ Hits        35495    35502    +7     
+ Misses      15705    15701    -4     
- Partials     2551     2552    +1     
Flag Coverage Δ
unittests 66.04% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot merged commit 1ffae87 into koordinator-sh:main Dec 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants