Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: refactor reset quota #2301

Merged

Conversation

shaloulcy
Copy link
Contributor

Ⅰ. Describe what this PR does

refact reset quota

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@shaloulcy shaloulcy force-pushed the refactor_reset_quota branch from c602067 to 862aa34 Compare December 23, 2024 07:11
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.00%. Comparing base (0615332) to head (19a05a5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   66.02%   66.00%   -0.03%     
==========================================
  Files         458      458              
  Lines       53791    53859      +68     
==========================================
+ Hits        35515    35548      +33     
- Misses      15725    15753      +28     
- Partials     2551     2558       +7     
Flag Coverage Δ
unittests 66.00% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube changed the title refactor reset quota scheduler: refactor reset quota Dec 23, 2024
@shaloulcy shaloulcy force-pushed the refactor_reset_quota branch from 862aa34 to 643ccca Compare December 23, 2024 11:17
Signed-off-by: chuanyun.lcy <[email protected]>
@shaloulcy shaloulcy force-pushed the refactor_reset_quota branch from 643ccca to 19a05a5 Compare December 23, 2024 11:18
@saintube
Copy link
Member

/lgtm

@saintube saintube added the lgtm label Dec 27, 2024
@hormes
Copy link
Member

hormes commented Jan 3, 2025

/approve

@koordinator-bot koordinator-bot bot merged commit b3ea5b6 into koordinator-sh:main Jan 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants