Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: register pod delete event for resource plugin #2308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.03%. Comparing base (e49c43d) to head (7ef2507).

Files with missing lines Patch % Lines
pkg/scheduler/plugins/deviceshare/plugin.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/loadaware/load_aware.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/nodenumaresource/plugin.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/reservation/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   66.03%   66.03%           
=======================================
  Files         458      458           
  Lines       53921    53925    +4     
=======================================
+ Hits        35607    35612    +5     
  Misses      15757    15757           
+ Partials     2557     2556    -1     
Flag Coverage Δ
unittests 66.03% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member

@ZiMengSheng Does ElasticQuota plugin need this? /cc @shaloulcy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants