Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML-CSS-Popup #743

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
190 changes: 190 additions & 0 deletions submissions/Cashass/HTML-CSS-Popup/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,190 @@
<!DOCTYPE html>
<html lang="ru">
<head>
<title>Popup-menu</title>
<link rel="stylesheet" href="style.css" />
<meta charset="UTF-8" />
<meta http-equiv="X-UA-Compatible" content="ie=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
</head>

<body>
<div class="wraper">
<header class="header">
<div class="container">
<nav class="header__menu">
<ul class="header__lists">
<li class="header__list">
<a href="#" class="header__link">Mail</a>
</li>
<li class="header__list">
<a href="#" class="header__link">Images</a>
</li>
<li class="header__list header__link">
<input
type="checkbox"
class="header__input"
id="header__input"
/>
<label for="header__input" class="header__input-label">
<img
src="icon/menu.png"
alt="menu"
class="header__logo-menu"
/>
</label>
<div class="popup">
<ul class="header__lists-popup">
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Безпека.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use English for filenames.

alt
/>Безпека</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Календар.png"
alt
/>Календар</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Калькулятор.png"
alt
/>Калькулятор</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Контакти.png"
alt
/>Контакти</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Контролер.png"
alt
/>Контролер</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Мапа.png"
alt
/>Мапа</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Новини.png"
alt
/>Новини</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Нотатки.png"
alt
/>Нотатки</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="popup-img"
src="icon/Поділитися.png"
alt
/>Поділитися</a
>
</li>
</ul>
<input
type="checkbox"
class="sub__check-input"
id="sub__input"
/>
<label for="sub__input" class="sub__check-label">
Більше
</label>
<div class="sub__lists-popup">
<ul class="sub__lists">
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="sub__popup-img"
src="icon/Поради.png"
alt
/>Поради</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="sub__popup-img"
src="icon/Пошта.png"
alt
/>Пошта</a
>
</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="sub__popup-img"
src="icon/Месенджер.png"
alt
/>Месенджер</a
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt must be equal to the empty string.
alt=''

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Changed file names to English. Add alt="". May I clarify? Can I leave a description of the "menu" and "View" icons? They carry meaning.

Copy link
Contributor

@OlexiyDobroskok OlexiyDobroskok Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I leave a description of the "menu" and "View" icons? They carry meaning.

Yes, you can.
If there is no text label on the menu button, you need to add alt-text. You can also describe its functionality in the code itself, like aria-label

</li>
<li class="popup__list">
<a href="#" class="popup__link">
<img
class="sub__popup-img"
src="icon/Синхронізація.png"
alt
/>Синхронізація</a
>
</li>
</ul>
</div>
</div>
</li>
<li class="header__list">
<a href="#" class="header__link">
<img
class="notification"
src="icon/bell.png"
alt="Повідомлення"
/>
</a>
</li>
<li class="header__list">
<a href="#" class="header__link">
<img class="Фото користувача" src="icon/avatar.png" alt="Аватар" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What means class="Фото користувача" ? =)
Do not write alt if the picture does not have a special meaning - for example avatars in the profile.
Where alt is inappropriate, use alt, which is equal to the empty string. alt=''

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I clarify? I can leave the description of the "menu" and "Повідомлення" icons. They carry meaning.

</a>
</li>
</ul>
</nav>
</div>
</header>
</div>
</body>
</html>
Loading