fix: for FB Creatives (#301)

* new regex fixed for FB * FB Creatives supported
krux · Jun 6, 2017 · c7e3d94 · c7e3d94
1 parent 56fb540
commit c7e3d94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/streamReaders.js b/src/streamReaders.js
@@ -7,8 +7,8 @@ import {CommentToken, CharsToken, StartTagToken,
  * @type {Object}
  */
 const REGEXES = {
-  startTag: /^<([\-A-Za-z0-9_]+)((?:\s+[\w\-]+(?:\s*=?\s*(?:(?:"[^"]*")|(?:'[^']*')|[^>\s]+))?)*)\s*(\/?)>/,
-  endTag: /^<\/([\-A-Za-z0-9_]+)[^>]*>/,
+  startTag: /^<([\-A-Za-z0-9_!:]+)((?:\s+[\w\-]+(?:\s*=?\s*(?:(?:"[^"]*")|(?:'[^']*')|[^>\s]+))?)*)\s*(\/?)>/,
+  endTag: /^<\/([\-A-Za-z0-9_:]+)[^>]*>/,
   attr: /(?:([\-A-Za-z0-9_]+)\s*=\s*(?:(?:"((?:\\.|[^"])*)")|(?:'((?:\\.|[^'])*)')|([^>\s]+)))|(?:([\-A-Za-z0-9_]+)(\s|$)+)/g,
   fillAttr: /^(checked|compact|declare|defer|disabled|ismap|multiple|nohref|noresize|noshade|nowrap|readonly|selected)$/i
 };

diff --git a/test/unit/tags.spec.js b/test/unit/tags.spec.js
@@ -34,6 +34,10 @@ describe('HtmlParser (tags)', () => {
       expect(s).to.equal('');
     }));
 
+    it('parses closed FB tags completely', parsesCompletely('<fb:ad placementid="1234" format="320x50" testmode="true">FB</fb:ad>', s => {
+      expect(s).to.equal('<fb:ad placementid="1234" format="320x50" testmode="true">FB</fb:ad>');
+    }));
+
     it('parses lower case tags', parses('<img src="http://localhost/">', (tok, str) => {
       expect(tok).to.have.property('tagName', 'img');
       expect(tok).to.have.property('type', 'startTag');