Support kubeedge 1.17 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qaplagzy
force-pushed
the
support-kubeedge-1.17
branch
from
6a7b687 to
73589cb
Compare
Qaplagzy
force-pushed
the
support-kubeedge-1.17
branch
2 times, most recently
from
8cbac94 to
823c5d0
Compare
wbc6080
reviewed
May 20, 2024
wbc6080
reviewed
May 20, 2024
There was a problem hiding this comment.
It seems that there will still be an error when deploying nginx pod https://github.com/kubeedge/keink/actions/runs/9155835162/job/25174615232?pr=16. Has this problem been solved before?
Signed-off-by: Bob <[email protected]>
Signed-off-by: Bob <[email protected]>
Qaplagzy
force-pushed
the
support-kubeedge-1.17
branch
3 times, most recently
from
dd6950f to
9a34490
Compare
wbc6080
reviewed
May 28, 2024
Qaplagzy
force-pushed
the
support-kubeedge-1.17
branch
from
9a34490 to
9fe88b7
Compare
wbc6080
reviewed
Jun 3, 2024
| } | ||
|
|
||
| // modify runtime to containerd | ||
| cmd = node.Command("bash", "-c", fmt.Sprintf(`sed -i -e "s|remoteImageEndpoint: .*|remoteImageEndpoint: %s|g" /etc/kubeedge/config/edgecore.yaml`, "unix:///var/run/containerd/containerd.sock")) | ||
| cmd = node.Command("bash", "-c", fmt.Sprintf(`sed -i -e "s|cgroupDriver: .*|cgroupDriver: systemd|g" /etc/kubeedge/config/edgecore.yaml`)) |
There was a problem hiding this comment.
Why modify to systemd here?
There was a problem hiding this comment.
I referred to an issue to resolve compatibility problems.
If not, it will error.
Qaplagzy
force-pushed
the
support-kubeedge-1.17
branch
from
9fe88b7 to
3771259
Compare
Signed-off-by: Bob <[email protected]>
Qaplagzy
force-pushed
the
support-kubeedge-1.17
branch
from
3771259 to
9e914a1
Compare
fisherxu
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support latest version in keink.
Which issue(s) this PR fixes:
Fixes #8
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE