1.fix bug：There is a memory leak in this part of the code

The image cache is applied in the lib library for transferring images, which needs to be released, otherwise there will be a memory leak 2.Modify data update strategy When the device's desire value is inconsistent with the report value, edgecore will re-deliver the desire value. This judgment will cause the desire value to fail to be delivered, because the desire value saved by the mapper has not changed. Signed-off-by: zhangyanhua <[email protected]>
kubeedge · Feb 15, 2023 · c7d53e0 · c7d53e0
1 parent 772aa38
commit c7d53e0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/mapper-sdk-go/internal/mqttadapter/subscribe.go b/mapper-sdk-go/internal/mqttadapter/subscribe.go
@@ -43,10 +43,6 @@ func SyncInfo(dic *di.Container, message mqtt.Message) {
 		if i == len(deviceInstances[instanceID].Twins) {
 			continue
 		}
-		// Desired value is not changed.
-		if deviceInstances[instanceID].Twins[i].Desired.Value == twinValue {
-			continue
-		}
 		if len(twinValue) > 30{
 			klog.V(4).Infof("Set %s:%s value to %s......", instanceID, twinName, twinValue[:30])
 		}else{

diff --git a/mappers/gige/driver/gigeclient.go b/mappers/gige/driver/gigeclient.go
@@ -293,6 +293,7 @@ func (gigEClient *GigEVisionDevice) PostImage(DeviceSN string) {
 	go func() {
 		var buffer []byte
 		var bufferHdr = (*reflect.SliceHeader)(unsafe.Pointer(&buffer))
+		defer C.free_image((**C.char)(unsafe.Pointer(&imageBuffer)))
 		bufferHdr.Data = uintptr(unsafe.Pointer(imageBuffer))
 		bufferHdr.Len = size
 		bufferHdr.Cap = size