Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Update tune API #2497

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

helenxie-bit
Copy link
Contributor

What this PR does / why we need it:
This PR includes the following updates to the tune API:

  • Enhanced Parameter Validation: Adds additional checks for input parameters to ensure better error handling and robustness.
  • Bug Fix for num_labels: Resolves an issue where the num_labels parameter was not being processed correctly.
  • Training Operator SDK Update: Updates the SDK version to include critical changes required for the trainer.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit
Copy link
Contributor Author

/cc @kubeflow/wg-automl-leads @Electronic-Waste @tariq-hasan @mahdikhashan @andreyvelich

@google-oss-prow google-oss-prow bot requested review from andreyvelich and a team January 18, 2025 07:16
Copy link

@helenxie-bit: GitHub didn't allow me to request PR reviews from the following users: tariq-hasan, mahdikhashan.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubeflow/wg-automl-leads @Electronic-Waste @tariq-hasan @mahdikhashan @andreyvelich

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helenxie-bit
Copy link
Contributor Author

/rerun-all

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @helenxie-bit!

if objective is not None:
if objective is not None or parameters is not None:
if not objective or not base_image or not parameters:
raise ValueError("One of the required parameters is None")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this validation if by default the base_image is the TensorFlow image ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, the check for base_image is unnecessary. My intention was to maintain consistency, which is why I included it. However, to avoid any confusion, I’ll go ahead and remove it. Thanks for pointing this out!

Signed-off-by: helenxie-bit <[email protected]>
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this! @helenxie-bit

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @helenxie-bit!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2567939 into kubeflow:master Jan 22, 2025
63 checks passed
mahdikhashan pushed a commit to mahdikhashan/katib that referenced this pull request Jan 27, 2025
* fix tune api error

Signed-off-by: helenxie-bit <[email protected]>

* delete check for

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
Signed-off-by: mahdikhashan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants