[SDK] Update tune API
#2497
[SDK] Update tune API
#2497
Conversation
Signed-off-by: helenxie-bit <[email protected]>
|
/cc @kubeflow/wg-automl-leads @Electronic-Waste @tariq-hasan @mahdikhashan @andreyvelich |
|
@helenxie-bit: GitHub didn't allow me to request PR reviews from the following users: tariq-hasan, mahdikhashan. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/rerun-all |
| if objective is not None: | ||
| if objective is not None or parameters is not None: | ||
| if not objective or not base_image or not parameters: | ||
| raise ValueError("One of the required parameters is None") |
There was a problem hiding this comment.
Why do we need this validation if by default the base_image is the TensorFlow image ?
There was a problem hiding this comment.
You're right, the check for base_image is unnecessary. My intention was to maintain consistency, which is why I included it. However, to avoid any confusion, I’ll go ahead and remove it. Thanks for pointing this out!
Signed-off-by: helenxie-bit <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, Electronic-Waste The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix tune api error Signed-off-by: helenxie-bit <[email protected]> * delete check for Signed-off-by: helenxie-bit <[email protected]> --------- Signed-off-by: helenxie-bit <[email protected]> Signed-off-by: mahdikhashan <[email protected]>
What this PR does / why we need it:
This PR includes the following updates to the
tuneAPI:num_labels: Resolves an issue where thenum_labelsparameter was not being processed correctly.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: