-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metadata envoy): upgrade envoy and config from 1.12 to 1.27 #10589
Conversation
Signed-off-by: Rentaro Matsukata <[email protected]>
Hi @freefood89. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As suggested by @rimolive I navigated to Executions, Artifacts, and then Lineage in Artifacts and I see no errors in the console or network tab of chrome dev tools. The run I used was "[Tutorial] DSL - Control structures" The kubeflow I'm using is 1.8 deployed using kubeflow/manifests |
Thank you for your contribution @freefood89 ! /ok-to-test |
This seems reasonable, and will help with the effort to make native ARM64 images: The old /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…flow#10589) Signed-off-by: Rentaro Matsukata <[email protected]>
…flow#10589) Signed-off-by: Rentaro Matsukata <[email protected]>
Description of your changes:
Upgrades envoy metadata proxy from 1.12 to 1.27 since 1.12 is no longer supported and is not receiving patches. I chose 1.27 because it's the version supported by the istio version I am using istio docs
This is my first PR here! I might need some help validating that this doesn't break anything.
closes #10578
Checklist: