Skip to content

✨Migrate autoscaling to AWS SDK V2 #5497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2025
Merged

✨Migrate autoscaling to AWS SDK V2 #5497

merged 1 commit into from
Jun 1, 2025

Conversation

alexander-demicev
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:
This PR migrates autoscaling to AWS SDK V2. I had to add some changes to IAM in the test package, which I will clean up in a separate PR together with the IAM migration.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5401

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Migrate autoscaling to AWS SDK V2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2025
@k8s-ci-robot k8s-ci-robot requested review from AndiDog and faiq May 16, 2025 14:26
@alexander-demicev alexander-demicev changed the title Migrate autoscaling to AWS SDK V2 ✨Migrate autoscaling to AWS SDK V2 May 16, 2025
@alexander-demicev
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@alexander-demicev: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alexander-demicev
Copy link
Contributor Author

@damdo @nrb ptal

@alexander-demicev
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@alexander-demicev
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@alexander-demicev
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Copy link
Contributor

nrb commented May 20, 2025

UnrecognizedClientException: The security token included in the request is invalid.

This happens occasionally. I wonder if the security token is expiring before the tests can actually start.

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

nrb
nrb reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, just a few questions on type changes that this introduces.

@alexander-demicev alexander-demicev force-pushed the sdkv2autoscaling branch 2 times, most recently from 8d9e0b8 to 63c6ae9 Compare May 21, 2025 10:12
@alexander-demicev alexander-demicev requested a review from nrb May 21, 2025 10:29
@alexander-demicev
Migrate autoscaling to AWS SDK V2
4e6ef24 
Signed-off-by: Alexandr Demicev <[email protected]>
@alexander-demicev
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

damdo
damdo reviewed May 23, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks a lot @alexander-demicev

/assign @richardcase

for a third pair of eyes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54b033b4a417be7fd20ce1bc73acf359c74bc353

@nrb
Copy link
Contributor

nrb commented Jun 1, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit af82f3a into kubernetes-sigs:main Jun 1, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v2.8 milestone Jun 1, 2025
@alexander-demicev alexander-demicev deleted the sdkv2autoscaling branch June 2, 2025 08:17
@AndiDog AndiDog mentioned this pull request Jun 4, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@AndiDog AndiDog Awaiting requested review from AndiDog

@faiq faiq Awaiting requested review from faiq

@nrb nrb Awaiting requested review from nrb

Assignees

@richardcase richardcase

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v2.8
Development

Successfully merging this pull request may close these issues.

Migrate autoscaling package to AWS SDK v2
5 participants
@alexander-demicev @k8s-ci-robot @nrb @damdo @richardcase