-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterctl: make clusterctl be available via go install #11466
Comments
This issue is currently awaiting triage. If CAPI contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Probably we should also prepare for golang/go#50603 /reopen Maybe we should open a separate issue for this, but reopening here until we move to a different one. |
@chrischdi: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/close Makeing a note for myself to add it to the Kubernetes v1.33 Bump issue as soon as it exists (this contains our go bump) |
@chrischdi: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What steps did you take and what happened?
related with #11464
Currently, clusterctl is unavailable via
go install
since a following error is occurred.This error is that why the clusterctl isn't embed the some versions since the
go install
doesn't use ldflag.To use go install is general way to install some binaries and this validation in clusterctl is only used to compare local version with latest version.
Since we can embed the these variables by providing the ldflags to the go install, I think it's better way to do comparison if these variables is set.
In additional, current comparison only check the patch version. So it doesn't suggest new clusterctl version when local clusterctl is vX.Y.Z and latest one is vX.Y+1.Z.
That's why, I think it's also better to fix this implementation.
What did you expect to happen?
Make clusterctl be available via go install.
Cluster API version
v1.8.5
Kubernetes version
No response
Anything else you would like to add?
No response
Label(s) to be applied
/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
/area clusterctl
The text was updated successfully, but these errors were encountered: