Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add support for clusterctl gitlab auth #11792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaxRink
Copy link
Contributor

@MaxRink MaxRink commented Feb 4, 2025

What this PR does / why we need it:
This PR adds support in clusterctl for gitlab instances that require auth.
Which issue(s) this PR fixes
Fixes # n/a

/area clusterctl

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2025
@MaxRink MaxRink force-pushed the clusterctl-gitlab-auth branch from 3e7775b to 7b1ee0f Compare February 4, 2025 15:54
@k8s-ci-robot
Copy link
Contributor

@MaxRink: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 7b1ee0f link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b5f06718de23cb19494e5fdd45ddc9c9f808fe5

@MaxRink
Copy link
Contributor Author

MaxRink commented Feb 18, 2025

@chrischdi The failing CI technically is a breaking API change.
I /could/ probably avoid it by not passing ctx and instead using ctx.background() but that would leave the gitlab implementation inconsistent with GitHub

@chrischdi
Copy link
Member

I think that change is okay as long as we do not cherry-pick this to an older release.

@chrischdi
Copy link
Member

Note we ~ did the same change for NewGithubRepository at this PR:

@sbueringer
Copy link
Member

We're good

https://github.com/kubernetes-sigs/cluster-api/tree/main/cmd/clusterctl#compatibility-notice

When this package is used as a library, we do not currently provide any compatibility guarantees. We will make reasonable efforts to follow a typical deprecation period prior to removal, but breaking changes can happen when necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants