-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ RuntimeSDK: add registry #6449
✨ RuntimeSDK: add registry #6449
Conversation
39b60ea
to
72a45c6
Compare
72a45c6
to
4614864
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small nits otherwise lgtm
Signed-off-by: Stefan Büringer [email protected] Co-authored-by: fabriziopandini <[email protected]>
4614864
to
33a6dc8
Compare
Findings should be addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/area runtime-sdk |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer [email protected]
Co-authored-by: fabriziopandini [email protected]
What this PR does / why we need it:
Credits to Fabrizio who did the initial implementation in our POC.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #6330