Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Runtime SDK client and Discovery #6455

Merged
merged 1 commit into from
May 11, 2022
Merged

✨ Runtime SDK client and Discovery #6455

merged 1 commit into from
May 11, 2022

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Apr 28, 2022 •
edited
Loading

What this PR does / why we need it:

This PR introduces the Discovery hooks and a runtime client. The runtime client can do discovery calls.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #6330

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 28, 2022
@chrischdi chrischdi mentioned this pull request Apr 29, 2022
Merged
2 tasks
sbueringer
sbueringer reviewed Apr 29, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
sbueringer
sbueringer reviewed Apr 29, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykakarap Looks very promising already.

Sorry I know it's a WIP PR, but I already provided some feedback as I don't have a lot of time next week.

exp/runtime/hooks/api/v1alpha1/discovery_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/discovery_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/discovery_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/discovery_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/doc.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client_test.go Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 30, 2022
@killianmuldoon
Copy link
Contributor

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2022
sbueringer
sbueringer reviewed May 10, 2022
View reviewed changes
exp/runtime/hooks/api/v1alpha1/discovery_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/doc.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/groupversion_info.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/util.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/util.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/util.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/catalog/catalog.go Outdated Show resolved Hide resolved
@ykakarap ykakarap changed the title ✨ [WIP] Runtime SDK client and Discovery ✨ Runtime SDK client and Discovery May 10, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2022
@chrischdi @sbueringer
Runtime SDK client and Discovery
cff9b2d 
Co-authored-by: chrischdi <[email protected]>
Co-authored-by: sbueringer <[email protected]>
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2022
@sbueringer sbueringer mentioned this pull request May 11, 2022
Closed
30 tasks
fabriziopandini
fabriziopandini reviewed May 11, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for follow up iterations but really looking forward to seeing this building block being used in the ExtensionConfig controller
/lgtm
/approve

Makefile Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/discovery_types.go Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/discovery_types.go Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit b53eacf into kubernetes-sigs:main May 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone May 11, 2022
@sbueringer sbueringer mentioned this pull request May 12, 2022
Closed
@killianmuldoon killianmuldoon mentioned this pull request May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ykakarap @killianmuldoon @sbueringer @k8s-ci-robot @chrischdi @fabriziopandini