✨ webhooks: defaulting and validation for ExtensionConfig #6475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
chrischdi
commented
May 3, 2022
chrischdi
commented
May 3, 2022
chrischdi
commented
May 3, 2022
chrischdi
force-pushed
the
pr-runtime-sdk-webhooks-extensionconfig
branch
from
f5481c5
to
224aef1
Compare
chrischdi
commented
May 3, 2022
ykakarap
reviewed
May 3, 2022
There was a problem hiding this comment.
This looks great! Thank you @chrischdi !!
Mostly just nits.
chrischdi
force-pushed
the
pr-runtime-sdk-webhooks-extensionconfig
branch
from
6175068
to
3a65c56
Compare
|
I will squash later on after further review. |
|
/area runtime-sdk |
ykakarap
reviewed
May 10, 2022
30 tasks
sbueringer
reviewed
May 11, 2022
chrischdi
force-pushed
the
pr-runtime-sdk-webhooks-extensionconfig
branch
2 times, most recently
from
f1813e4
to
2dbe5e5
Compare
|
Thx! lgtm pending squash from my side |
Co-authored-by: Yuvaraj Kakaraparthi <[email protected]> Co-authored-by: Christian Schlotter <[email protected]>
chrischdi
force-pushed
the
pr-runtime-sdk-webhooks-extensionconfig
branch
from
2dbe5e5
to
ce89e60
Compare
|
Squashed the commits :-) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Yuvaraj Kakaraparthi [email protected]
Co-authored-by: Christian Schlotter [email protected]
What this PR does / why we need it:
Adds defaulting and advanced validation for Runtime SDK's ExtensionConfig.
Credits to Yuvaraj who did the implementation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #6330