🌱 Add client defaulting and validation for DiscoveryResponse #6578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
30 tasks
killianmuldoon
commented
May 31, 2022
ykakarap
reviewed
Jun 1, 2022
k8s-ci-robot
added
the
needs-rebase
killianmuldoon
force-pushed
the
runtimeSDK/discovery-validation
branch
from
cf0ed86
to
7f3481d
Compare
k8s-ci-robot
removed
the
needs-rebase
killianmuldoon
force-pushed
the
runtimeSDK/discovery-validation
branch
from
7f3481d
to
2fcbfbb
Compare
sbueringer
reviewed
Jun 9, 2022
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@killianmuldoon it seems it is required to run |
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
runtimeSDK/discovery-validation
branch
from
8d95774
to
10bd788
Compare
k8s-ci-robot
removed
the
lgtm
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon [email protected]
Adds some basic validation and defaulting rules to the runtime SDK client on Discovery of Extension Handlers.
Part of #6330