Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implements BeforeClusterDelete hook #6644

Merged
merged 1 commit into from
Jul 1, 2022
Merged

✨ Implements BeforeClusterDelete hook #6644

merged 1 commit into from
Jul 1, 2022

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR implements the BeforeClusterDelete hook.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6546

Important Links:

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2022
@ykakarap
Copy link
Contributor Author

/hold
until #6629 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@ykakarap ykakarap mentioned this pull request Jun 14, 2022
Merged
@sbueringer sbueringer mentioned this pull request Jun 14, 2022
Closed
8 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2022
@killianmuldoon killianmuldoon mentioned this pull request Jun 17, 2022
Merged
@ykakarap ykakarap force-pushed the runtime-sdk_lifecycle-hooks_delete-hook branch from e6661e8 to fd93736 Compare June 28, 2022 00:03
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 28, 2022
sbueringer
sbueringer reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize PR Is still WIP, just did a high level review and added some comments, PR looks good overall (assuming it works :))

config/webhook/manifests.yaml Outdated Show resolved Hide resolved
controllers/alias.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/cluster_controller.go Outdated Show resolved Hide resolved
internal/webhooks/runtime/cluster.go Outdated Show resolved Hide resolved
internal/hooks/tracking.go Outdated Show resolved Hide resolved
internal/webhooks/runtime/cluster.go Outdated Show resolved Hide resolved
@ykakarap ykakarap force-pushed the runtime-sdk_lifecycle-hooks_delete-hook branch from fd93736 to f76e203 Compare June 28, 2022 21:14
@ykakarap
Copy link
Contributor Author

/retest

@ykakarap
Copy link
Contributor Author

/retest

flake

@ykakarap ykakarap changed the title ✨ [WIP] Implements BeforeClusterDelete hook ✨ Implements BeforeClusterDelete hook Jun 29, 2022
@ykakarap ykakarap mentioned this pull request Jun 29, 2022
Merged
@sbueringer
Copy link
Member

lgtm pending squash

cc @killianmuldoon @chrischdi for review when you have some time

chrischdi
chrischdi reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nits / comment foo :-)

/lgtm

internal/hooks/tracking.go Show resolved Hide resolved
internal/controllers/topology/cluster/cluster_controller.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/cluster_controller.go Outdated Show resolved Hide resolved
internal/hooks/tracking.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2022
@ykakarap ykakarap force-pushed the runtime-sdk_lifecycle-hooks_delete-hook branch from 4b07b53 to 5e1d960 Compare June 30, 2022 17:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2022
@sbueringer
Copy link
Member

Looks good

/lgtm

Would probably merge tomorrow

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2022
@ykakarap
Copy link
Contributor Author

/retest

@killianmuldoon
Copy link
Contributor

/lgtm

@sbueringer
Copy link
Member

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2022
@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 82d823b into kubernetes-sigs:main Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 1, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 1, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #6802

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ykakarap @sbueringer @killianmuldoon @k8s-infra-cherrypick-robot @k8s-ci-robot @chrischdi