Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 RuntimeSDK: enforce https for extensions #6645

Merged
merged 1 commit into from
Jun 15, 2022
Merged

🌱 RuntimeSDK: enforce https for extensions #6645

merged 1 commit into from
Jun 15, 2022

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Jun 14, 2022 •
edited
Loading

What this PR does / why we need it:

This PR does:

  • adjusts the Runtime SDKs hook client to enforce usage of TLS for calling Hooks
  • adjusts the validation for ExtensionConfigs to block an ExtensionConfig which defines an url having http scheme
  • adjusts tests because they now have to use https

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Part of:

Follow-up of

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2022
@chrischdi chrischdi changed the title RuntimeSDK: enforce https for extensions 🌱 RuntimeSDK: enforce https for extensions Jun 14, 2022
sbueringer
sbueringer reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx looks good. One comment

internal/runtime/client/client.go Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-runtimesdk-enforce-https branch from eb60884 to ac2c073 Compare June 14, 2022 08:42
@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
killianmuldoon
killianmuldoon approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer sbueringer added the area/runtime-sdk Issues or PRs related to Runtime SDK label Jun 14, 2022
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
fabriziopandini
fabriziopandini reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/retest
flake

@k8s-ci-robot k8s-ci-robot merged commit 7dd216c into kubernetes-sigs:main Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 15, 2022
@sbueringer sbueringer mentioned this pull request Jun 15, 2022
Closed
30 tasks
@chrischdi chrischdi deleted the pr-runtimesdk-enforce-https branch June 30, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@chrischdi @sbueringer @k8s-ci-robot @fabriziopandini @killianmuldoon