Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 🌱 Initial e2e test for Runtime SDK lifecycle hook #6702

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[release-1.2] 🌱 Initial e2e test for Runtime SDK lifecycle hook #6702

merged 1 commit into from
Jun 23, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #6664

/assign fabriziopandini

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 22, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 22, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2022
ykakarap
ykakarap approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@sbueringer sbueringer force-pushed the cherry-pick-6664-to-release-1.2 branch from c2e029c to 61827b2 Compare June 23, 2022 09:58
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2022
@sbueringer
Copy link
Member

sbueringer commented Jun 23, 2022 •
edited
Loading

@killianmuldoon looks like it works now
(left lgtm to you)

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@sbueringer
Copy link
Member

/hold
Have to take a look at the commits

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2022
@killianmuldoon @sbueringer
Add lifecycle hook handlers to test extension
6258c4b 
Signed-off-by: killianmuldoon <[email protected]>
Co-authored-by: ykakarap <[email protected]>
@sbueringer sbueringer force-pushed the cherry-pick-6664-to-release-1.2 branch from 61827b2 to 6258c4b Compare June 23, 2022 10:05
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 23, 2022
@sbueringer
Copy link
Member

/hold cancel
/approve
Should be fine now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

killianmuldoon
killianmuldoon approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit e9e6ee4 into kubernetes-sigs:release-1.2 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@ykakarap ykakarap ykakarap approved these changes

@sbueringer sbueringer Awaiting requested review from sbueringer

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @ykakarap @killianmuldoon @fabriziopandini