-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 add disclaimer about clusterctl topology dryrun RuntimeSDK support #6830
📖 add disclaimer about clusterctl topology dryrun RuntimeSDK support #6830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making the SSA support and the RuntimeSDK points as separate bullet points? But keep both the points in the Limitations
block.
Not sure the SSA section is 3 separate sections (+ one of them contains a listing). I would probably prefer making it a separate note if we want to split it up |
+1 to splitting it up. |
636091f
to
5ad0b90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.2 |
@sbueringer: new pull request created: #6852 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Adds a disclaimer that clusterctl topology dryrun doesn't support RuntimeSDK yet.
When using the command with a ClusterClass with external patching the following error is produced:
I can change/improve that but it would require ~ something like this: https://github.com/kubernetes-sigs/cluster-api/compare/main...sbueringer:cluster-api:poc-clusterctl-runtimesdk?expand=1
Please note adding the disclaimer is just a stop gap solution until we got around to implementing it correctly in clusterctl (see #6545)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #6330