Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 add disclaimer about clusterctl topology dryrun RuntimeSDK support #6830

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 5, 2022

What this PR does / why we need it:
Adds a disclaimer that clusterctl topology dryrun doesn't support RuntimeSDK yet.

When using the command with a ClusterClass with external patching the following error is produced:

➜ ${CAPI_HOME}/bin/clusterctl alpha topology plan -f docker-cluster.yaml -f docker-clusterclass.yaml --output-directory=/tmp/test
Detected a cluster with Cluster API installed. Will use it to fetch missing objects.
Error: failed defaulting and validation on input objects: failed to run defaulting and validation on ClusterClasses: failed validation of cluster.x-k8s.io/v1beta1, Kind=ClusterClass default/quick-start: ClusterClass.cluster.x-k8s.io "quick-start" is invalid: spec.patches[0].external: Forbidden: patch.external can be used only if the RuntimeSDK feature flag is enabled

I can change/improve that but it would require ~ something like this: https://github.com/kubernetes-sigs/cluster-api/compare/main...sbueringer:cluster-api:poc-clusterctl-runtimesdk?expand=1

Please note adding the disclaimer is just a stop gap solution until we got around to implementing it correctly in clusterctl (see #6545)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6330

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2022
@sbueringer sbueringer changed the title doc: add disclaimer about clusterctl topology dryrun RuntimeSDK support 📖 add disclaimer about clusterctl topology dryrun RuntimeSDK support Jul 5, 2022
@sbueringer
Copy link
Member Author

/cc @fabriziopandini @ykakarap

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@sbueringer sbueringer mentioned this pull request Jul 5, 2022
30 tasks
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making the SSA support and the RuntimeSDK points as separate bullet points? But keep both the points in the Limitations block.

@sbueringer
Copy link
Member Author

sbueringer commented Jul 5, 2022

How about making the SSA support and the RuntimeSDK points as separate bullet points? But keep both the points in the Limitations block.

Not sure the SSA section is 3 separate sections (+ one of them contains a listing). I would probably prefer making it a separate note if we want to split it up

@ykakarap
Copy link
Contributor

ykakarap commented Jul 6, 2022

Not sure the SSA section is 3 separate sections (+ one of them contains a listing). I would probably prefer making it a separate note if we want to split it up

+1 to splitting it up.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2022
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit ce12106 into kubernetes-sigs:main Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 6, 2022
@sbueringer sbueringer deleted the pr-topoloyg-dryrun-doc branch July 7, 2022 05:45
@sbueringer
Copy link
Member Author

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6852

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants