variable name changes from callingObject to callingObjects

kubernetes-sigs · Aug 21, 2024 · a8f9f22 · a8f9f22
1 parent 26a0cf0
commit a8f9f22
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 16 deletions.
diff --git a/PROVIDER.md b/PROVIDER.md
@@ -143,9 +143,9 @@ package examplegateway
 
 import "github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/notifications"
 
-func notify(mType notifications.MessageType, message string) {
-	newNotification := notifications.Notification{Type: mType, Message: message}
-    notifications.CommonNotification.DispatchNotication(newNotification, string(ProviderName))
+func notify(mType notifications.MessageType, message string, callingObjects ...client.Object){
+	newNotification := notifications.NewNotification(mType, message, callingObjects...)
+	notifications.NotificationAggr.DispatchNotification(newNotification, string(ProviderName))
 }
 ```
 7. Import the new package at `cmd/print`.

diff --git a/pkg/i2gw/notifications/notifications.go b/pkg/i2gw/notifications/notifications.go
@@ -53,7 +53,7 @@ var NotificationAggr NotificationAggregator
 
 // NotificationCallback is a callback function used to send notifications from within the common
 // package without the common package having knowledge about which provider is making a call it
-type NotificationCallback func(mType MessageType, message string, callingObject ...client.Object)
+type NotificationCallback func(mType MessageType, message string, CallingObjects ...client.Object)
 
 // DispatchNotification is used to send a notification to the NotificationAggregator
 func (na *NotificationAggregator) DispatchNotification(notification Notification, ProviderName string) {
@@ -103,6 +103,6 @@ func convertObjectsToStr(ob []client.Object) string {
 	return sb.String()
 }
 
-func NewNotification(mType MessageType, message string, callingObject ...client.Object) Notification {
-	return Notification{Type: mType, Message: message, CallingObjects: callingObject}
+func NewNotification(mType MessageType, message string, callingObjects ...client.Object) Notification {
+	return Notification{Type: mType, Message: message, CallingObjects: callingObjects}
 }
diff --git a/pkg/i2gw/providers/apisix/notification.go b/pkg/i2gw/providers/apisix/notification.go
@@ -21,7 +21,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-func notify(mType notifications.MessageType, message string, callingObject ...client.Object) {
-	newNotification := notifications.NewNotification(mType, message, callingObject...)
+func notify(mType notifications.MessageType, message string, callingObjects ...client.Object) {
+	newNotification := notifications.NewNotification(mType, message, callingObjects...)
 	notifications.NotificationAggr.DispatchNotification(newNotification, string(Name))
 }
diff --git a/pkg/i2gw/providers/gce/notification.go b/pkg/i2gw/providers/gce/notification.go
@@ -21,7 +21,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-func notify(mType notifications.MessageType, message string, callingObject ...client.Object) {
-	newNotification := notifications.NewNotification(mType, message, callingObject...)
+func notify(mType notifications.MessageType, message string, callingObjects ...client.Object) {
+	newNotification := notifications.NewNotification(mType, message, callingObjects...)
 	notifications.NotificationAggr.DispatchNotification(newNotification, string(ProviderName))
 }
diff --git a/pkg/i2gw/providers/ingressnginx/notification.go b/pkg/i2gw/providers/ingressnginx/notification.go
@@ -21,7 +21,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-func notify(mType notifications.MessageType, message string, callingObject ...client.Object) {
-	newNotification := notifications.NewNotification(mType, message, callingObject...)
+func notify(mType notifications.MessageType, message string, callingObjects ...client.Object) {
+	newNotification := notifications.NewNotification(mType, message, callingObjects...)
 	notifications.NotificationAggr.DispatchNotification(newNotification, string(Name))
 }
diff --git a/pkg/i2gw/providers/istio/notification.go b/pkg/i2gw/providers/istio/notification.go
@@ -21,7 +21,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-func notify(mType notifications.MessageType, message string, callingObject ...client.Object) {
-	newNotification := notifications.NewNotification(mType, message, callingObject...)
+func notify(mType notifications.MessageType, message string, callingObjects ...client.Object) {
+	newNotification := notifications.NewNotification(mType, message, callingObjects...)
 	notifications.NotificationAggr.DispatchNotification(newNotification, string(ProviderName))
 }
diff --git a/pkg/i2gw/providers/kong/notification.go b/pkg/i2gw/providers/kong/notification.go
@@ -21,8 +21,8 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-func notify(mType notifications.MessageType, message string, callingObject ...client.Object) {
-	newNotification := notifications.NewNotification(mType, message, callingObject...)
+func notify(mType notifications.MessageType, message string, callingObjects ...client.Object) {
+	newNotification := notifications.NewNotification(mType, message, callingObjects...)
 	notifications.NotificationAggr.DispatchNotification(newNotification, string(Name))
 }