Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added notifications in the common package #180

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added notifications in the common package #180

wants to merge 4 commits into from

Conversation

Devaansh-Kumar
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds notifications from the common package

Which issue(s) this PR fixes:

This pull request addresses part of the issue described in #131

Does this PR introduce a user-facing change?:

Added notifications from the common package

/cc @mlavacca @LiorLieberman

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Devaansh-Kumar
Once this PR has been reviewed and has the lgtm label, please assign youngnick for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Devaansh-Kumar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2024
mlavacca
mlavacca reviewed Aug 20, 2024
View reviewed changes
pkg/i2gw/providers/common/utils.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/common/utils.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/common/utils.go Outdated Show resolved Hide resolved
pkg/i2gw/providers/common/converter.go Outdated Show resolved Hide resolved
@mlavacca
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2024
@Devaansh-Kumar Devaansh-Kumar force-pushed the common-package-notification-callback branch from f0bf4ab to 26a0cf0 Compare August 20, 2024 17:51
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2024
LiorLieberman
LiorLieberman reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tests for it

@Devaansh-Kumar
Copy link
Contributor Author

Could you tell how can we structure tests for this?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@Devaansh-Kumar Devaansh-Kumar force-pushed the common-package-notification-callback branch from a8f9f22 to 5a08a3c Compare October 9, 2024 17:12
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2024
@Devaansh-Kumar Devaansh-Kumar force-pushed the common-package-notification-callback branch from 5a08a3c to 9988220 Compare November 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca Awaiting requested review from mlavacca

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Devaansh-Kumar @k8s-ci-robot @mlavacca @LiorLieberman