Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kindnetd: use different values than kube-network-policies #3761

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Kindnetd: use different values than kube-network-policies #3761

merged 2 commits into from
Nov 5, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Oct 23, 2024

No description provided.

@aojea
kindnet: don't collide with kube-network-policies
a345ebe 
kindnet revendors the kube-network-policies controller, if it uses the
same values then there can be problems if both projects run in the same
cluster.

Change-Id: I0daad4e6979aff57e56cfacd876bd9101c3199cd
@aojea
bump kindnetd image
859303d 
Change-Id: I946930647aa1338686cacd2f06e9f6f0f6a4e59c
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2024
@aojea
Copy link
Contributor Author

aojea commented Oct 23, 2024

/assign @BenTheElder
/cc @tssurya

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2024
BenTheElder
BenTheElder reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit c022884 into kubernetes-sigs:main Nov 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@neolit123 neolit123 Awaiting requested review from neolit123

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aojea @k8s-ci-robot @BenTheElder