Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version tags for 3rd party GH Actions #3770

Closed
wants to merge 1 commit into from

Conversation

stmcginnis
Copy link
Contributor

This switches our third party GitHub Action references to use the major version tag rather than the SHA. This means the actions will automatically use the latest tag within that versions, and Dependabot updates will only be necessary when there is a major version bump where we will want to evaluate the included changes before updating.

This switches our third party GitHub Action references to use the major
version tag rather than the SHA. This means the actions will
automatically use the latest tag within that versions, and Dependabot
updates will only be necessary when there is a major version bump where
we will want to evaluate the included changes before updating.

Signed-off-by: Sean McGinnis <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stmcginnis
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2024
@BenTheElder
Copy link
Member

This switches our third party GitHub Action references to use the major version tag rather than the SHA. This means the actions will automatically use the latest tag within that versions, and Dependabot updates will only be necessary when there is a major version bump where we will want to evaluate the included changes before updating.

We used shas intentionally because it means that you have T.O.F.U. and you don't have any surprise changes. The dependabot PRs can be reverted, but we can't go revert their tag changes.

@stmcginnis
Copy link
Contributor Author

I thought that might be the case. 👍

@stmcginnis stmcginnis closed this Oct 28, 2024
@BenTheElder
Copy link
Member

@aojea might have other thoughts, but I think especially "we can trivially revert any issues" is worth it, even if we wind up with more dependabot PRs to review :-)

@aojea
Copy link
Contributor

aojea commented Oct 29, 2024

No strong opinion here, I always prefer pinned dependencies, I don't really had much issues with GitHub actions dependencies so I can't really say ... I expect them to be very stable

@BenTheElder
Copy link
Member

I don't really had much issues with GitHub actions dependencies so I can't really say ... I expect them to be very stable

There's also the concern about effectively curl | bash into your CI infra (versus e.g. at least hash pinning) behind a mutable pointer. We currently don't allow github actions access to much but ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants