fix: set global arp_ignore param for kindnet #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/test all |
aojea
reviewed
Mar 2, 2025
shaneutt
force-pushed
the
shaneutt/fix-arp-ignore
branch
from
d5bd098 to
0671ecd
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
aojea
reviewed
Mar 11, 2025
Some Linux distributions set this to 2 or higher, which will break kindnet (specifically the ptp plugin). We now set this in our base image in an opinionated way so that the host system no longer decides the value as it might inadvertantly break kind networking. Signed-off-by: Shane Utt <[email protected]>
shaneutt
force-pushed
the
shaneutt/fix-arp-ignore
branch
from
0671ecd to
5e66ec0
Compare
|
Thanks! FYI: this will be exercised in CI on the next PR after the image is built (postsubmit), similar to agnhost changes in kubernetes/kubernetes. I don't expect to need to revert, but just calling out that while CI ran, really all of the e2e jobs didn't test this yet, we'll get that in the next step. /lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel Thanks @shaneutt |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3880
If we do decide to go this way, in my testing setting
1appears to work properly, and since this is the first time we've been opinionated about it it seems like an opportunity to set it as restrictively as we can tolerate. However we went with a setting of0because that has been the historically anticipated setting.