[WIP] Cni kindnet #3882
[WIP] Cni kindnet #3882
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/XXL
| @@ -165,26 +165,16 @@ RUN git clone --filter=tree:0 "${CRI_TOOLS_CLONE_URL}" /cri-tools \ | |||
| && make BUILD_BIN_PATH=./build crictl \ | |||
| && GOARCH=$TARGETARCH go-licenses save --save_path=/_LICENSES ./cmd/crictl | |||
|
|
|||
| # stage for building cni-plugins | |||
| # stage for building cni-plugin | |||
There was a problem hiding this comment.
hmm, this has a risk of skewing with kindnetd right?
we probably need to think about that, though I'm not sure what the best option is.
we could modify the node image build to handle this but I'm not sure that's better
| [plugins."io.containerd.grpc.v1.cri".cni] | ||
| # use_internal_loopback use an internal mechanism to set lo to up on containers | ||
| # instead of the CNI loopback plugin | ||
| use_internal_loopback = true |
There was a problem hiding this comment.
do you have more details about this?
| "plugins": [ | ||
| { | ||
| "type": "cni-kindnet", | ||
| "ranges": [ |
There was a problem hiding this comment.
I feel like the name here could be slightly more descriptive as to the purpose?
|
/close I thought we had a bug, but it turned out to be other thing, this is not solving any problem we have today in kind, current setup has not had any bug in years, so we should be fine with it |
|
@aojea: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Simplify the network stack by using the cni-kindnet standalone plugin, that contains all the functionality we were using in a single binary, so we don't have to chain different plugins.
https://kindnet.es/docs/design/cni/
Fixes: #3880