Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pickdeep plugin #4394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

flavono123
Copy link

introducing plugin pickdeep(kupid).

kupid

not only as single binary(kupid) but also for a krew plugin can be installed and used, tested on my personal index.

so actually i just did copy the Plugin resource from my index, let me know what if i have to do more works.

further details on https://github.com/flavono123/kupid thx!

Signed-off-by: flavono123 <[email protected]>
@ahmetb
Copy link
Member

ahmetb commented Feb 6, 2025

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flavono123
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2025
matchLabels:
os: darwin
arch: amd64
shortDescription: Pick any Deep schema fields, create your own table view of Kubernetes TUI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi we truncate after 55 chars

arch: amd64
shortDescription: Pick any Deep schema fields, create your own table view of Kubernetes TUI.
homepage: https://github.com/flavono123/kupid
description: Pick any Deep schema fields, create your own table view of Kubernetes TUI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about something more explanatory for these descriptions:

Short: Interactively choose get output columns

Long: This is an interactive tool to pick which resource fields you want to show in the kubectl get output.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. and the short one will be represented in https://krew.sigs.k8s.io/plugins/ here right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants