-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pickdeep plugin #4394
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: flavono123 <[email protected]>
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flavono123 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
plugins/pickdeep.yaml
Outdated
matchLabels: | ||
os: darwin | ||
arch: amd64 | ||
shortDescription: Pick any Deep schema fields, create your own table view of Kubernetes TUI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fyi we truncate after 55 chars
plugins/pickdeep.yaml
Outdated
arch: amd64 | ||
shortDescription: Pick any Deep schema fields, create your own table view of Kubernetes TUI. | ||
homepage: https://github.com/flavono123/kupid | ||
description: Pick any Deep schema fields, create your own table view of Kubernetes TUI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about something more explanatory for these descriptions:
Short: Interactively choose get output columns
Long: This is an interactive tool to pick which resource fields you want to show in the kubectl get output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. and the short one will be represented in https://krew.sigs.k8s.io/plugins/ here right?
Signed-off-by: flavono123 <[email protected]>
introducing plugin
pickdeep
(kupid).not only as single binary(kupid) but also for a krew plugin can be installed and used, tested on my personal index.
so actually i just did copy the Plugin resource from my index, let me know what if i have to do more works.
further details on https://github.com/flavono123/kupid thx!