[kjobctl] Move SBATCH_ variables to entrypoint script. #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/cc @trasc |
trasc
reviewed
Oct 22, 2024
cmd/experimental/kjobctl/pkg/builder/templates/slurm_entrypoint_script.sh.tmpl
Outdated
Show resolved
Hide resolved
mbobrovskyi
force-pushed
the
cleanup/move-sbatch-variables-to-entrypoint-script
branch
from
a3ef17f
to
99e18dc
Compare
mbobrovskyi
force-pushed
the
cleanup/move-sbatch-variables-to-entrypoint-script
branch
from
99e18dc
to
3c80a8d
Compare
mbobrovskyi
changed the title
mbobrovskyi
changed the title
mbobrovskyi
force-pushed
the
cleanup/move-sbatch-variables-to-entrypoint-script
branch
from
3c80a8d
to
60d666c
Compare
mbobrovskyi
changed the title
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fed2f38e3640265b07e75140d44f83617baf948e
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mbobrovskyi
deleted the
cleanup/move-sbatch-variables-to-entrypoint-script
branch
PBundyra
pushed a commit
to PBundyra/kueue
that referenced
this pull request
Nov 5, 2024
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Move SBATCH_ variables to entrypoint script in kjobctl Slurm mode.
Which issue(s) this PR fixes:
Prepare #3269.
Special notes for your reviewer:
Sbatch variables are not using in init-entrypoint.sh, so there's no need to generate them in the init script.
Does this PR introduce a user-facing change?