[kjobctl] Move common SLURM_envs to container env vars.

[mbobrovskyi]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move common SLURM_ envs to container env vars on kjobctl.

Which issue(s) this PR fixes:

Prepare #3269

Special notes for your reviewer:

We have many variables that are the same in each container, so there's no need to generate them in the init container. Instead of that we can set it as a container env vars on builder.

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign trasc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cmd/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	f1b4e3c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/671876ba1623560008b06e04

[mwielgus]

I'm afraid this will make the already big slurm job/pod definition significantly bigger. Is why is it needed?

[mbobrovskyi]

Is why is it needed?

We discussed on the previous weekly meeting to create init container on go. Before that trying to optimize init script.

[mbobrovskyi]

In another way we need to create a lot of flags for go slurm-init to send all of this values.

@mimowo @trasc WDYT?

[mbobrovskyi]

Another approach I also can see to get it from configmap.

[mwielgus]

Configmap sounds ok.

[trasc]

In another way we need to create a lot of flags for go slurm-init to send all of this values.

@mimowo @trasc WDYT?

I don't think that loading the env vars from a = separated file is such a big challenge in a go app (split by \n then by =). So, at least for now, we should not add an extra config map just for this.

[mbobrovskyi]

/close

In the case where we are using the current ConfigMap, it will be addressed in #3293.

[k8s-ci-robot]

@mbobrovskyi: Closed this PR.

In response to this:

/close

In the case where we are using the current ConfigMap, it will be addressed in #3293.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.