Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement or Remove TODO Comment in VPA Estimator #7528

Closed
omerap12 opened this issue Nov 24, 2024 · 3 comments · Fixed by #7546
Closed

Implement or Remove TODO Comment in VPA Estimator #7528

omerap12 opened this issue Nov 24, 2024 · 3 comments · Fixed by #7546
Assignees
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@omerap12
Copy link
Member

Which component are you using?:
VPA

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
We currently have a TODO comment in the code: comment. This has been there for a while without anyone implementing it. I’m wondering if it's still relevant. Either way, we should either implement the change or remove the comment.

Describe the solution you'd like.:
I propose implementing the separation, which would allow us to further extend the VPA's capabilities. However, I’m also fine with keeping the VPA as it currently is.

Describe any alternative solutions you've considered.:
Simply delete the comment.

Additional context.:
NONE

@omerap12 omerap12 added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2024
@omerap12
Copy link
Member Author

/area vertical-pod-autoscaler

@adrianmoisey
Copy link
Member

I see value in separating the estimator, I agree in the reason for doing so.

However, if we deleted the comment and did the separation later, I don't think that would hurt the project either.

@omerap12
Copy link
Member Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants