VPA(feat): separate estimator object for CPU and memory #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Aplatony <[email protected]>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
adrianmoisey
reviewed
Dec 1, 2024
adrianmoisey
reviewed
Dec 1, 2024
vertical-pod-autoscaler/pkg/recommender/logic/estimator_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Moisey <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
Signed-off-by: Omer Aplatony <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@raywainman , can you PTAL? |
raywainman
reviewed
Dec 9, 2024
| @@ -118,43 +180,58 @@ func getConfidence(s *model.AggregateContainerState) float64 { | |||
| return math.Min(lifespanInDays, samplesAmount) | |||
| } | |||
|
|
|||
| // Returns resources computed by the underlying estimator, scaled based on the | |||
There was a problem hiding this comment.
This comment seems useful to preserve. Should we keep it for the new function signatures?
There was a problem hiding this comment.
yeah I agree. Ill revert
|
Thank you for the change, just 1 quick comment then I think this is good to go. |
Signed-off-by: Omer Aplatony <[email protected]>
k8s-ci-robot
added
size/XL
|
/lgtm /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces separate estimator objects for CPU and memory.
Which issue(s) this PR fixes:
Fixes #7528
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: