-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for VPA and sig-autoscaling #7532
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Holding this for now. There is discussion about adding the docs to k/website. Once we have actual useful docs, we can then speak to sig-docs about how to get them into k/website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know the VPA that well, so i'm not the best person for the content of the docs but i have a comments so far:
- depending on what we want to do with this PR, we might want to drop the github action just to make our intentions clearer. we want to get the docs in order, then figure out how to work with sig-docs to get them in the core.
- we might want to leave the README.md file in the root of the VPA directory so that we can direct users to the new documentation location. i'm guessing that vpa users might be aware of the readme already, so we don't want to create a situation where it's gone all of sudden.
also, i was thinking about how we might want to document the cluster-autoscaler stuff and i think it will be challenging to solve this problem due to the providers. i think it's possible we could migrate the core CA docs, but we would want to have links for the provider specific pieces since those docs are owned by the various providers. |
Oh, @elmiko, is it possible that you reviewed the wrong PR? This PR is the one that I first made, to try add rendered docs to the VPA. It started the conversation about where docs should live. Then I made #7548 as a test of "what would it look like if all the .md files lived in a single directory", hoping that the layout would allow for more fluid documentation creation. I'll close this one to avoid confusion. |
lol, my bad @adrianmoisey , i had this window open. i will review the /other/ one, thanks! |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Use mkdocs to improve the look and feel of the VPA's documentation
Also add a sig-autoscaling site that redirects users to the location of the docs for each component
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
index.yaml
file is handled when deploying the docs, but, I don't know if the workflow that deploys theindex.yaml
will handle the docs existingA note on local development:
python3 -m venv venv
. ./venv/bin/activate
pip install -r docs/requirements.txt
mkdocs
:mkdocs build --config-file "docs/mkdocs-root.yml"
,mkdocs build --config-file "docs/mkdocs-vertical-pod-autoscaler"
(or replacebuild
withserve
)Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: