-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP 4960: Container Stop Signals #5122
Merged
k8s-ci-robot
merged 16 commits into
kubernetes:master
from
sreeram-venkitesh:kep-4960-container-stop-signals
Feb 13, 2025
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
43784e7
Added initial draft of KEP 4960
sreeram-venkitesh f750d66
Added thockin and mrunalp as reviewers
sreeram-venkitesh 6cc0e8c
nits from review
sreeram-venkitesh 2393c27
typo fix
sreeram-venkitesh f5406b6
Updated API to new lifecycle hook, use ContainerConfig instead of Sto…
sreeram-venkitesh e126a5f
Added prr approver
sreeram-venkitesh 710611b
Fixed TOC
sreeram-venkitesh 760c51d
Updated API to lifecycle.StopSignal instead of lifecycle.stop.signal
sreeram-venkitesh 4f9db20
Fixed TOC
sreeram-venkitesh 9508d34
Clarified version skew with static pods, alternative with prestop hook
sreeram-venkitesh 7eadd9f
Clarified PRR question about reenabling feature gate
sreeram-venkitesh f83edd3
Updated PRR approver, addressed comments from PRR review
sreeram-venkitesh c04e3e0
Fix typo
sreeram-venkitesh 9101efb
Added section on windows support
sreeram-venkitesh ede63f3
Fix toc
sreeram-venkitesh d29143f
Clarified hcsshim in Windows containers
sreeram-venkitesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| kep-number: 4960 | ||
| alpha: | ||
| approver: "@jpbetz" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to pick up for Joe. Can you make this @deads2k?