-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-1645: define dual stack policies and fields #5264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
MrFreezeex
commented
Apr 29, 2025
- One-line PR description: Define dual stack recommendations and fields
- Issue link: Multi-Cluster Services API #1645
- Other comments: This does three things: define initial suggestion as to what an implementation may do to support dual stack services, fix the max items for the IPs field (which is already fixed in the actual CRD) and add a IPfamilies matching the same field in the Service that implementation may use to reconcile this globally with an implementation defined policy.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrFreezeex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
e8481cf
to
092d90e
Compare
ipFamilies: | ||
- IPv4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, IPV4 and IPV6 format are quite different, are the formats in the "ips" field alone not enough for the consumer to discern? I assume that the consumer knows what IP family it can support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is more aimed toward the allocation of the IPs
than what happens after the IPs
are already actually allocated a bit like the current type
field or even how the ipFamilies
field behave on a regular Service.
For instance for Cilium we would most likely want to do an intersection of all the ipFamilies
in the exported Services which would put this as relevant as the other fields to "allocate" the IPs
(meaning to create the derived service as it how we do this) to us essentially.