Skip to content

[WIP] KEP-5334: Image Pull Progress #5335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] KEP-5334: Image Pull Progress #5335

wants to merge 1 commit into from

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented May 23, 2025 •
edited
Loading

  • One-line PR description: Use kubectl to view the progress of pulling the image of the pod
  • Other comments:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wzshiming
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2025
@wzshiming wzshiming mentioned this pull request May 23, 2025
Open
4 tasks
@wzshiming wzshiming force-pushed the kep-5334 branch 7 times, most recently from d1363c6 to 08e2a89 Compare May 23, 2025 11:55
This was referenced May 23, 2025
Open
Closed
@wzshiming wzshiming force-pushed the kep-5334 branch 3 times, most recently from e74154d to 82a29fb Compare May 23, 2025 12:40
haircommander
haircommander reviewed May 30, 2025
View reviewed changes
keps/sig-node/5334-image-pull-progrss/README.md Outdated

Proposed changes to the kubectl:

It is expected to be implemented on Bate
Copy link
Contributor

@haircommander haircommander May 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: beta

also, I think this should be implemented in alpha 2

Actually sorry I though this was about the kubelet changes, I agree the kubectl changes can come in later (though maybe alpha 2 would be best)

haircommander
haircommander reviewed May 30, 2025
View reviewed changes
keps/sig-node/5334-image-pull-progrss/README.md

It is expected to be implemented after the CRI implementation supporting the CRI API is released.

- Add a new route `/imagePullProgress/{podNamespace}/{podID}` to the Kubelet server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is camel case typical for http endpoints like this? it seems a bit odd to me but I'm not familiar with convention

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is the typical camel case. I am referring to the portForward endpoint.

https://github.com/kubernetes/kubernetes/blob/fd53f7292c7d5899135fddd928c0dc3844126820/pkg/kubelet/server/server.go#L556

@k8s-ci-robot
Copy link
Contributor

@wzshiming: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-enhancements-verify 1186899 link true /test pull-enhancements-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzshiming @k8s-ci-robot @haircommander