KEP-3695: Add updates around e2e tests #5430
+16
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -265,6 +265,12 @@ These cases will be added in the existing e2e tests: | |
| - Get API work with DRA and device plugin. | ||
| - List API work with DRA and Device plugin. | ||
|
|
||
| [Get](https://github.com/kubernetes/kubernetes/pull/116846): [sig-node-kubelet](https://testgrid.k8s.io/sig-node-kubelet?include-filter-by-regex=PodResources), [triage](https://storage.googleapis.com/k8s-triage/index.html?test=PodResources) | ||
|
|
||
| Other improvements are addressed in: | ||
| - https://github.com/kubernetes/kubernetes/pull/132028 | ||
| - https://github.com/kubernetes/kubernetes/pull/132345 | ||
|
There was a problem hiding this comment. Those are fine, since those are no-merged PRs, so when updating this the next time you'll be able to replace these with appropriate links and descriptions like above. |
||
|
|
||
|
Comment on lines
+270
to
+273
There was a problem hiding this comment. I think, but please doublecheck, is better not to link PRs in the KEP but rather describe the goal these PR implement.
So I'd just remove lines 270-272 |
||
| ### Graduation Criteria | ||
|
|
||
| #### Alpha | ||
|
|
@@ -282,6 +288,13 @@ These cases will be added in the existing e2e tests: | |
|
|
||
| - [ ] Allowing time for feedback (1 year). | ||
| - [ ] Risks have been addressed. | ||
| - [ ] Add explicit feature enablement/disablement tests, before the feature is turned on by default. | ||
| - [ ] Additional test cases are needed to verify Get() behavior in diverse scenarios | ||
| - Pods with multiple containers. | ||
| - Pods that do not use any exclusive resources. | ||
| - Comparison of List() and Get() on returned pods to validate consistency. | ||
| - Pod exists but container name is invalid | ||
| - Get() is called on terminated pods to validate appropriate error handling. | ||
|
|
||
| ### Upgrade / Downgrade Strategy | ||
|
|
||
|
|
@@ -334,7 +347,9 @@ The API becomes available again. The API is stateless, so no recovery is needed, | |
|
|
||
| ###### Are there any tests for feature enablement/disablement? | ||
|
|
||
| This e2e test (https://github.com/kubernetes/kubernetes/pull/116846) will demonstrate that when the feature gate is disabled, the API returns the appropriate error code. The explicit on/off tests are scattered across the existing tests: | ||
|
There was a problem hiding this comment. Again, replace the PR link with code pointers to https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/podresources_test.go |
||
| - https://github.com/kubernetes/kubernetes/blob/v1.34.0-alpha.1/test/e2e_node/podresources_test.go#L977 | ||
| - https://github.com/kubernetes/kubernetes/blob/v1.34.0-alpha.1/test/e2e_node/podresources_test.go#L1066 | ||
|
Comment on lines
+350
to
+352
There was a problem hiding this comment. ...and we should rectify that and have this test clear and explicit |
||
|
|
||
| ### Rollout, Upgrade and Rollback Planning | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR link should be replaced with actual code links to https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/podresources_test.go