Skip to content

KEP-5419: Add non-goals, and risks and mitigations #5432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-5419: Add non-goals, and risks and mitigations #5432

wants to merge 1 commit into from

Conversation

ndixita
Copy link
Contributor

@ndixita ndixita commented Jun 21, 2025 •
edited
Loading

  • One-line PR description: Adding non goals and risks and mitigations section

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ndixita
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2025
@ndixita ndixita marked this pull request as ready for review June 21, 2025 18:42
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp June 21, 2025 18:42
SergeyKanzhelev
SergeyKanzhelev reviewed Jun 21, 2025
View reviewed changes
keps/sig-node/5419-pod-level-resources-in-place-resize/README.md
2. This KEP does not aim to implement dynamic changes to a pod's QoS class based on
in-place resource resize operations.

3. No dynamic adjustments for Init Containers that have already finished and can't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that resize request will be declined? What if I want to change sizes for the next execution? Why would we limit this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(next execution may be on node restart)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyKanzhelev I have added this one to align with the one mentioned in KEP 1287 https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1287-in-place-update-pod-resources/README.md#sidecars

@ndixita ndixita force-pushed the pod-level-resources-ippr-alpha branch from 465fa8f to ae98bf7 Compare June 21, 2025 19:17
@lmktfy
Copy link

lmktfy commented Jun 22, 2025

/retitle KEP-5419: Add non-goals, and risks and mitigations

@k8s-ci-robot k8s-ci-robot changed the title Adding non goals and risks and mitigations KEP-5419: Add non-goals, and risks and mitigations Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndixita @k8s-ci-robot @lmktfy @SergeyKanzhelev