Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to install ingress-nginx plugin with krew! #12226

Open
zhumeishuai opened this issue Oct 23, 2024 · 8 comments
Open

Failed to install ingress-nginx plugin with krew! #12226

zhumeishuai opened this issue Oct 23, 2024 · 8 comments
Assignees
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@zhumeishuai
Copy link

Installing ingress-nginx plugin with krew failed with an error download https://github.com/kubernetes/ingress-nginx/releases/download/controller-0.31.0/kubectl-ingress_nginx-linux-amd64.tar.gz 404.
I tried my best on the search engines, but couldn't find any relevant information.
image

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Oct 23, 2024
@strongjz strongjz self-assigned this Oct 24, 2024
@zhumeishuai
Copy link
Author

Is there any way to solve it?

@zhumeishuai
Copy link
Author

@strongjz Is there any way to solve it?

@strongjz
Copy link
Member

strongjz commented Nov 6, 2024

0.31.0 controller is no longer supported. To my understanding, the plugin version should match the controller version.

@gianarb
Copy link

gianarb commented Nov 7, 2024

Hello @strongjz I have facing the same issue.

I use helm to install nginx in my kubernetes cluster. Currently this is the helm version:

  repository = "https://kubernetes.github.io/ingress-nginx"
  chart      = "ingress-nginx"
  version    = "4.11.3"

At the best of my knowledge it is the latest released by this project.

Looking at the nginx controller image deployed this is what I have:

  Containers:
   controller:
    Image:           registry.k8s.io/ingress-nginx/controller:v1.11.3@sha256:d56f135b6462cfc476447cfe564b83a45e8bb7da2774963b00d12161112270b7
    Ports:           80/TCP, 443/TCP, 8443/TCP
    Host Ports:      0/TCP, 0/TCP, 0/TCP
    SeccompProfile:  RuntimeDefault

I can't find 0.31.0 anywhere in my system, so I am not sure why krew is looking for such version. Unfortunately I am debugging an issue for one of my cluster. I can't really dig deeper, but I will be back with more if I can find what is going on.

In the meantime I am gonna build the plugin from source

@mhbahmani
Copy link

Same issue here. Is there any solution for this?

@threadcrux
Copy link

threadcrux commented Dec 2, 2024

See my related issue filed here in krew repo: kubernetes-sigs/krew-index#4254

This is not a solution but shedding more light on the situation. The plugin definition has not been updated in 4+ years.

There is also a secondary issue, the plugin is based upon the controller releases that used to provide builds for different platforms/architectures. It no longer looks like the release system is providing builds.

Ping:
@cpanato
@Gacko
@puerco
@rikatz
@strongjz
@tao12345666333

Sorry about the ping blast. What needs to be done to get platform/architecture builds reestablished for the above? I can provide the fix in the krew repo but there is nothing to point the plugin definitions at.

I am also unsure of which version would be best for the plugin definition

@threadcrux
Copy link

threadcrux commented Dec 2, 2024

I started to reverse engineer what happened. The MakeFile no longer has a build-plugin target and the associated build-plugin.sh script is missing.

I filed an issue for those here:
#12436

Looks like it was removed here, and then nothing has happened since:
#8812

Not sure why removing the build script for manual building was the idea thrown around. Anyways there is a github action for this but not entirely sure its working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

6 participants