Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MakeFile build-plugin, and build-plugin bash script #12436

Open
threadcrux opened this issue Dec 2, 2024 · 2 comments
Open

Missing MakeFile build-plugin, and build-plugin bash script #12436

threadcrux opened this issue Dec 2, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@threadcrux
Copy link

threadcrux commented Dec 2, 2024

Build-plugin associated build files are missing

.PHONY: build-plugin
build-plugin:  ## Build ingress-nginx krew plugin.
        @build/run-in-docker.sh \
                PKG=$(PKG) \
                ARCH=$(ARCH) \
                COMMIT_SHA=$(COMMIT_SHA) \
                REPO_INFO=$(REPO_INFO) \
                TAG=$(TAG) \
                GOBUILD_FLAGS=$(GOBUILD_FLAGS) \
                build/build-plugin.sh

Originally in the sourcecode way back here https://github.com/kubernetes/ingress-nginx/blob/controller-v0.35.0/Makefile#L89

Also the build-plugin.sh build script here:

https://github.com/kubernetes/ingress-nginx/blob/controller-v0.35.0/build/build-plugin.sh

Related to this issue: #12226

@threadcrux threadcrux added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@threadcrux threadcrux changed the title Missing MakeFile build-plugin Missing MakeFile build-plugin, and build-plugin bash script Dec 2, 2024
@threadcrux
Copy link
Author

threadcrux commented Dec 2, 2024

Related:
#8812
#7627

This is where it was removed and it looks like nothing has happened since. Why was the Makefile and Build scripts removed? Automated build systems should utilize Makefiles and build scripts not post-exempt them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

2 participants