Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote registry.k8s.io/images/k8s-staging-cloud-provider-gcp/images.… #7762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YifeiZhuang
Copy link

@YifeiZhuang YifeiZhuang commented Feb 6, 2025

…yaml release-1.30

release-1.30 image

docker pull gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:release-1.30
release-1.30: Pulling from k8s-staging-cloud-provider-gcp/cloud-controller-manager
Digest: sha256:c877fb8ec7da679fe7e571eee42f7659db92c3a3a970f9340c598e97ff438585
Status: Image is up to date for gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:release-1.30
gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:release-1.30

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YifeiZhuang
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @YifeiZhuang!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @YifeiZhuang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2025
@YifeiZhuang
Copy link
Author

/assign aojea

@YifeiZhuang
Copy link
Author

@mattcary or @saikat-royc could you please take a look, thank you.

@aojea
Copy link
Member

aojea commented Feb 9, 2025

please add the description the origin of the sha , you can take a look to existing PRs , since there are multiple ways of doing it

#5970
#7667
...

we need to use a image tag that matches the versioning of the repo, we are using tags and not branches

@YifeiZhuang
Copy link
Author

YifeiZhuang commented Feb 10, 2025

@aojea sounds fair.
The sha was actually indicated from the tool that supposed to create the PR automatically.

kpromo  pr --fork  YifeiZhuang --interactive --project cloud-provider-gcp --tag release-1.30

However, I ran into permission issue by running the command. So the PR is created manually. But I verified the tag and the sha from the gcr.io console:
https://screenshot.googleplex.com/5yagM6fZKq59NW3

@YifeiZhuang
Copy link
Author

@aojea actually I got the kpromo tool to work properly, see auto generated PR: #7775 where the sha digest is the same.

However, #7775 also includes gcp-controller-manager component that is not the scope of CCM anymore. So I'll just keep this PR.

@YifeiZhuang
Copy link
Author

@aojea a kind reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants