Skip to content

Remove Type field details addition in sync-bug-triage-github-project-beta.sh #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rajalakshmi-Girish
Copy link

What type of PR is this:

/kind cleanup

What this PR does / why we need it:

periodic-sync-bug-triage-github-project-beta-1-34
has been failing with below error:

Starting sync...
[INFO] Fetching the list of open issues and PRs from k/k under the current release milestone, v1.34
[INFO] Getting metadata for the Bug Triage GitHub Beta Project with ID: 80
[INFO] Feeding data from k/k issues into the GitHub Project Beta
gh: Could not resolve to a node with the global id of ''

The Bug Traige board does not need the information if the item is an issue/pr. The icon against each row indicated it's Type.

Special notes for your reviewer:

New changes in GH https://github.com/github/docs/commits/main/content/issues/tracking-your-work-with-issues/configuring-issues/managing-issue-types-in-an-organization.md

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels May 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rajalakshmi-Girish
Once this PR has been reviewed and has the lgtm label, please assign fsmunoz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from katcosgrove May 21, 2025 11:06
@k8s-ci-robot k8s-ci-robot added the area/release-team Issues or PRs related to the release-team subproject label May 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Verolop May 21, 2025 11:06
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2025
@wendy-ha18
Copy link
Member

LGTM

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 22, 2025

Folks, feel free to take the final call. 🙂

Just adding some context behind the original Type field with multi-value options (PR and Issue) — it was added to get a filtered view and a quick total count of Issue and PR items tracked by the bug triage team.

Example of such a filtered view:

image


I used the following patch to fix the script

(rename the field Type -> Tracking Type.
Found the Tracking Type field in the GH board template used by the Release Team)

diff --git a/release-team/hack/sync-bug-triage-github-project-beta.sh b/release-team/hack/sync-bug-triage-github-project-beta.sh
index 903d022b..dfdab0a0 100755
--- a/release-team/hack/sync-bug-triage-github-project-beta.sh
+++ b/release-team/hack/sync-bug-triage-github-project-beta.sh
@@ -54,13 +54,13 @@ function get_field_ids_from_github_beta_project() {
         query='.data.organization.projectV2.id'
     elif [ "$1" == "type-id" ]
     then
-        query='.data.organization.projectV2.fields.nodes[] | select(.name== "Type") | .id'
+        query='.data.organization.projectV2.fields.nodes[] | select(.name== "Tracking Type") | .id'
     elif [ "$1" == "issue-id" ]
     then
-        query='.data.organization.projectV2.fields.nodes[] | select(.name== "Type") | .options[] | select(.name== "Issue") | .id'
+        query='.data.organization.projectV2.fields.nodes[] | select(.name== "Tracking Type") | .options[] | select(.name== "Issue") | .id'
     # for "pr-id"
     else
-        query='.data.organization.projectV2.fields.nodes[] | select(.name== "Type") | .options[] | select(.name== "PR") | .id'
+        query='.data.organization.projectV2.fields.nodes[] | select(.name== "Tracking Type") | .options[] | select(.name== "PR") | .id'
     fi
 
     ID="$( gh api graphql -f query='

@Priyankasaggu11929
Copy link
Member

Also, testing the PR changes locally. I'm getting following error:

❯ MILESTONE=1.34 GITHUB_TOKEN=<gh-PAT-token> PROJECT_NUMBER=219 ./sync-script-pr-2788.sh

Starting sync...
[INFO] Fetching the list of open issues and PRs from k/k under the current release milestone, 1.34
[INFO] Getting metadata for the Bug Triage GitHub Beta Project with ID: 219
[INFO] Feeding data from k/k issues into the GitHub Project Beta
gh: Argument 'fieldId' on InputObject 'UpdateProjectV2ItemFieldValueInput' is required. Expected type ID!
Argument 'value' on InputObject 'UpdateProjectV2ItemFieldValueInput' is required. Expected type ProjectV2FieldValue!

@Priyankasaggu11929
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2025
@Rajalakshmi-Girish
Copy link
Author

@Priyankasaggu11929, following your comment, renaming the field from Type to Tracking Type seems reasonable.

Would it be appropriate for me to go ahead and submit the changes you suggested in this PR?

@wendy-ha18 @Vyom-Yadav — I’d appreciate your input on whether this approach makes the most sense moving forward.

@wendy-ha18
Copy link
Member

I also think using Tracking Type is better than removing it completely, at least for now. @Vyom-Yadav it's your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants