Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend retryCmd with configurable retry and bo factor #16107

Closed
wants to merge 1 commit into from

Conversation

clarketm
Copy link
Contributor

@clarketm clarketm commented Feb 3, 2020

Modify retryCmd so that it accepts a number of tries and a backoffFactor.

Note: Using retries=3 and backoffFactor=1 will retain the original behavior of retryCmd (i.e. base 2 exponential). In this PR, I am also increasing the tries to 5 in an attempt to mitigate the issue described: #16130

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 3, 2020
@clarketm
Copy link
Contributor Author

clarketm commented Feb 3, 2020

/assign @stevekuznetsov @cjwagner

Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clarketm, petr-muller
To complete the pull request process, please assign cjwagner
You can assign the PR to them by writing /assign @cjwagner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clarketm
Copy link
Contributor Author

clarketm commented Feb 4, 2020

/hold

I received a response from the GitHub support ticket I filed for the "not our ref" issue that drove this change. I will open an issue to summarize the problem and track the alternatives given for mitigation (including increasing retries), so the ultimate solution can be informed and objective.

#16130

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2020
@clarketm
Copy link
Contributor Author

Can we approve/merge this as mitigation until a more permanent solution is implemented?

@clarketm clarketm closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants