Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: Add golvuncheck for 3.4, 3.5 #32801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

etcd: Add golvuncheck for 3.4, 3.5 #32801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/jobs/etcd/etcd-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ presubmits:
optional: true # remove this once the job is green
branches:
- main
- release-3.5
- release-3.4
Comment on lines +126 to +127
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that 3.5 and 3.4 do not have run-govulncheck in Makefile?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ivanvc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that 3.5 and 3.4 do not have run-govulncheck in Makefile?

Yes, it needs to be backported

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no test.sh we can add the govuln_pass() function in test_lib.sh for 3.4, 3.5 branches.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OR
we can fix the presubmit to not depend on Makefile and pass the direct commands to run

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no test.sh we can add the govuln_pass() function in test_lib.sh for 3.4, 3.5 branches.

For release-3.5 test.sh is at the root project directory not in scripts/. Imo we should be backporting the Makefile recipe along with changes to test.sh so tests are run in a uniform way where possible. Otherwise we create cognitive burden when switching between working on different branches.

decorate: true
annotations:
testgrid-dashboards: sig-etcd-presubmits
Expand Down