replicate crio presubmits using kubetest2

[elieser1101]

This is part of an effort to start using kubetest2 for crio e2e node tests. Being tracked in #32567. starting with presubmits

[k8s-ci-robot]

Hi @elieser1101. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elieser1101]

/cc krzyzacy

[kannon92]

can you combine the presubmits into a single PR?

[krzyzacy]

/ok-to-test

[krzyzacy]

^^ Indentation here is wrong

/hold

[krzyzacy]

also +1 to can you combine the presubmits into a single PR? :-)

[kannon92]

@elieser1101
Thank you for taking this work on. I went ahead and closed the other PRs. Please combine all these presubmits into a single PR.

/hold

[elieser1101]

Thanks for the help, sorry for the noise.
Think now everything is in place

@kannon92 @krzyzacy

[kannon92]

/hold cancel

[kannon92]

At a glance this looks good to me.

So we want to add the kubetest2 jobs and leave the nonkubetest ones around,

When will we remove the legacy jobs?

[kannon92]

Have you confirmed that the tests that have merged already are working without issue?

[elieser1101]

The idea would be to merge these test, then create a PR on which validate all the kubetest2 presubmits works as expected and refactor anything broken.

After we validate these new test consistently work for some period of time(not sure how much) then we can remove the legacy ones?

[kannon92]

You merged a canary one a few weeks ago. Have you tested that one to see if it worked?

[elieser1101]

3 out of 5 of the merged PR were tested and worked here:
kubernetes/kubernetes#120459

[krzyzacy]

I'm fine with adding these jobs since they are optional and non-blocking, we need to be a bit careful when we removing the older jobs and make sure the new ones become blocking and don't accidentally lose coverage

[krzyzacy]

(see if @kannon92 has any further concerns, otherwise I'll be happy to approve this bulk and track triaging in kubernetes/kubernetes#127831)

[elieser1101]

sure, my plan is keep working on this till test are fully working

[krzyzacy]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elieser1101, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-node/OWNERS [krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@elieser1101: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

This is part of an effort to start using kubetest2 for crio e2e node tests. Being tracked in #32567. starting with presubmits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pohly]

pull-kubernetes-node-e2e-crio-cgrpv1-dra-kubetest2 and pull-kubernetes-node-e2e-crio-cgrpv2-dra-kubetest2 are not working. Apparently the --label-filter argument is passed to kubetest2, which fails (Error: unknown flag: --label-filter).

cc @klueska @bart0sh