-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase ginkgo timeout for serial jobs on kubetest2 #33694
increase ginkgo timeout for serial jobs on kubetest2 #33694
Conversation
Hi @elieser1101. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold please let's try to be more rigorous with these kind of changes the log you link indicates a timeout ... from one specific test, not of the job
The job runs in 30 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elieser1101, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aojea the non kubetest job takes about 3 hours. This finishing in 30 minutes is a bug from converting to kubetest2. |
independently, it runs now in 30 minutes, changing the timeout will not make any difference, the job will still be running in 30 minutes anyway, I let you handle this since migrations require a lot of try and error /hold cancel |
@elieser1101: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Serial jobs seem to be timing out https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/128092/pull-kubernetes-node-kubelet-serial-crio-cgroupv1-kubetest2/1847639771518603264/artifacts/build-log.txt
this should fix it.
part of #32567