Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase ginkgo timeout for serial jobs on kubetest2 #33694

Conversation

elieser1101
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @elieser1101. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 21, 2024
@aojea
Copy link
Member

aojea commented Oct 21, 2024

/hold

please let's try to be more rigorous with these kind of changes

the log you link indicates a timeout ... from one specific test, not of the job


Summarizing 1 Failure:
  [TIMEDOUT] [sig-node] Device Plugin [NodeFeature:DevicePlugin] [Serial] DevicePlugin [Serial] [Disruptive] [AfterEach] Can schedule a pod with a restartable init container [NodeFeature:SidecarContainers] [sig-node, NodeFeature:DevicePlugin, Serial, Disruptive, NodeFeature:SidecarContainers]
  k8s.io/kubernetes/test/e2e_node/device_plugin_test.go:198

Ran 22 of 667 Specs in 1801.678 seconds
FAIL! - Suite Timeout Elapsed -- 21 Passed | 1 Failed | 0 Pending | 645 Skipped
--- FAIL: TestE2eNode (1801.71s)
FAIL

Ginkgo ran 1 suite in 30m1.856789007s

The job runs in 30 minutes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elieser1101, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@kannon92
Copy link
Contributor

@aojea the non kubetest job takes about 3 hours. This finishing in 30 minutes is a bug from converting to kubetest2.

@aojea
Copy link
Member

aojea commented Oct 21, 2024

@aojea the non kubetest job takes about 3 hours. This finishing in 30 minutes is a bug from converting to kubetest2.

independently, it runs now in 30 minutes, changing the timeout will not make any difference, the job will still be running in 30 minutes

anyway, I let you handle this since migrations require a lot of try and error

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3da8688 into kubernetes:master Oct 21, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@elieser1101: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Serial jobs seem to be timing out https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/128092/pull-kubernetes-node-kubelet-serial-crio-cgroupv1-kubetest2/1847639771518603264/artifacts/build-log.txt
this should fix it.

part of #32567

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants