add mising timeouts for imagefs and splitfs jobs on kubetest2 migration

[elieser1101]

Still missing the timeout needed in node-e2e

I1123 11:15:28.590442   10178 ssh.go:146] Running the command ssh, with args: [-o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR -i /root/.ssh/google_compute_engine [email protected] -- sudo /bin/bash -c 'cd /tmp/node-e2e-20241123T111515 && set -o pipefail; timeout -k 30s 0.000000s ./ginkgo -timeout=24h -nodes=8  -focus="\[NodeConformance\]|\[NodeFeature:.+\]|\[NodeFeature\]"  -skip="\[Flaky\]|\[Slow\]|\[Serial\]"  --no-color -v --timeout=30m ./e2e_node.test -- --system-spec-name= --system-spec-file= --extra-envs= --runtime-config= --v 4 --node-name=n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5 --report-dir=/tmp/node-e2e-20241123T111515/results --report-prefix=fedora --image-description="fedora-coreos-41-20241027-3-0-gcp-x86-64" --kubelet-flags="--cluster-domain=cluster.local" --dns-domain="cluster.local" --prepull-images=false  --container-runtime-endpoint=unix:///run/containerd/containerd.sock --ginkgo.timeout=3h --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}" 2>&1 | tee -i /tmp/node-e2e-20241123T111515/results/n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5-ginkgo.log']

in particular this bit show it does not have the timeout set

... timeout -k 30s 0.000000s ./ginkgo ...

traking it here kubernetes/kubernetes#128092

failing jobs

pull-kubernetes-node-crio-cgrpv2-imagefs-e2e-kubetest2
pull-kubernetes-node-crio-cgrpv2-splitfs-e2e-kubetest2

part of #32567

[k8s-ci-robot]

Hi @elieser1101. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elieser1101]

cc: @kannon92

[kannon92]

/ok-to-test

I don’t think this will work. I think the ginkgo timeout command is needed ginkgo.timeout. You can find other examples for the serial kubetest jobs.

[elieser1101]

this changes includes the kubetest2 --timeout which kubetest2 uses to pass the TIMEOUT var to the makefile wich i think is used to tell the run_remote.go for how long to wait for ginkgo test.

for this two particular jobs we are already passing the ginko.timeout which is consumed by ginkgo itself

i'm trying to get the command executed by the e2e to match with the non-kubetest2 and this seems to be one of the missing things

[kannon92]

let's try it.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elieser1101, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-node/OWNERS [kannon92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kannon92]

I think we can merge this as this is an optional PR for the release so I don't see a reason to wait until 1.33 opens up.

[k8s-ci-robot]

@elieser1101: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Still missing the timeout needed in node-e2e

I1123 11:15:28.590442   10178 ssh.go:146] Running the command ssh, with args: [-o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR -i /root/.ssh/google_compute_engine [email protected] -- sudo /bin/bash -c 'cd /tmp/node-e2e-20241123T111515 && set -o pipefail; timeout -k 30s 0.000000s ./ginkgo -timeout=24h -nodes=8  -focus="\[NodeConformance\]|\[NodeFeature:.+\]|\[NodeFeature\]"  -skip="\[Flaky\]|\[Slow\]|\[Serial\]"  --no-color -v --timeout=30m ./e2e_node.test -- --system-spec-name= --system-spec-file= --extra-envs= --runtime-config= --v 4 --node-name=n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5 --report-dir=/tmp/node-e2e-20241123T111515/results --report-prefix=fedora --image-description="fedora-coreos-41-20241027-3-0-gcp-x86-64" --kubelet-flags="--cluster-domain=cluster.local" --dns-domain="cluster.local" --prepull-images=false  --container-runtime-endpoint=unix:///run/containerd/containerd.sock --ginkgo.timeout=3h --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}" 2>&1 | tee -i /tmp/node-e2e-20241123T111515/results/n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5-ginkgo.log']

in particular this bit show it does not have the timeout set

... timeout -k 30s 0.000000s ./ginkgo ...

traking it here kubernetes/kubernetes#128092

failing jobs

pull-kubernetes-node-crio-cgrpv2-imagefs-e2e-kubetest2
pull-kubernetes-node-crio-cgrpv2-splitfs-e2e-kubetest2

part of #32567

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.