Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify container kill/restart scenario #48827

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hayk96
Copy link

@hayk96 hayk96 commented Nov 24, 2024

What this PR does / why we need it:

  • In the Pod Quality of Service Classes documentation page, there is a section: Some behavior is independent of QoS class does not clearly mention when the Kubelet kills or restarts a container. Since the Kubelet restarts containers only when they exceed memory limits, this PR adds clarity on that aspect.

Copy link

linux-foundation-easycla bot commented Nov 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hayk96 / name: Hayk Davtyan (a160d60)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @hayk96!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 24, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 24, 2024
Copy link

netlify bot commented Nov 24, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a160d60
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6744d41db23aa20008b8cd0a
😎 Deploy Preview https://deploy-preview-48827--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hayk96 Thanks for your contribution. It appears that this PR includes changes to files across multiple languages English (en) and Chinese (zh-cn). However, docs follows different processes for each localization, and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only the primary website content (which means only English content) initially with this PR. After the merge of the English content, we could create separate pull request for the remaining language(s). I hope this suggestion is helpful.

@dipesh-rawat
Copy link
Member

Explicit hold until this PR only covers one language.
(Ok to unhold once that's done)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hayk96
Copy link
Author

hayk96 commented Nov 25, 2024

Thank you for your feedback @dipesh-rawat. I have updated the PR.

@T-Lakshmi
Copy link
Contributor

/remove-language zh

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Nov 27, 2024
@hayk96 hayk96 requested a review from dipesh-rawat November 28, 2024 21:45
@sftim
Copy link
Contributor

sftim commented Dec 2, 2024

/remove-area localization
/remove-hold

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/localization General issues or PRs related to localization labels Dec 2, 2024
Comment on lines +108 to 109
* Any Container exceeding a memory limit will be killed and restarted by the kubelet without
affecting other Containers in that Pod.
Copy link
Contributor

@sftim sftim Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why you've proposed this change, but:

  • actually it's often not the kubelet that kills the container
  • for memory, OOM kill may not trigger the moment that the resource limit is exceeded
  • Kubernetes might one day add support for another resource that has a similar allocation to memory, and the original text would be more helpful

[Containers in] Pods can never use more CPU than their limit, because the kernel intercedes. However, that's more a special quality of the CPU resource, where you can't exceed the limit even if you try to.

If someone made a mechanism for containers to be able to use more CPU (eg cooperative realtime), but with a risk of termination if the task didn't yield as agreed, the original statement might still apply.

I am not sure we should make this change as drafted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants