-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify container kill/restart scenario #48827
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: hayk96 <[email protected]>
|
Welcome @hayk96! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hayk96 Thanks for your contribution. It appears that this PR includes changes to files across multiple languages English (en) and Chinese (zh-cn). However, docs follows different processes for each localization, and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only the primary website content (which means only English content) initially with this PR. After the merge of the English content, we could create separate pull request for the remaining language(s). I hope this suggestion is helpful.
Explicit hold until this PR only covers one language. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your feedback @dipesh-rawat. I have updated the PR. |
/remove-language zh |
/remove-area localization |
* Any Container exceeding a memory limit will be killed and restarted by the kubelet without | ||
affecting other Containers in that Pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see why you've proposed this change, but:
- actually it's often not the kubelet that kills the container
- for memory, OOM kill may not trigger the moment that the resource limit is exceeded
- Kubernetes might one day add support for another resource that has a similar allocation to memory, and the original text would be more helpful
[Containers in] Pods can never use more CPU than their limit, because the kernel intercedes. However, that's more a special quality of the CPU resource, where you can't exceed the limit even if you try to.
If someone made a mechanism for containers to be able to use more CPU (eg cooperative realtime), but with a risk of termination if the task didn't yield as agreed, the original statement might still apply.
I am not sure we should make this change as drafted.
What this PR does / why we need it: